Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36161][docs]Update Integration Test Example with Sink API. #25590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RanJinh
Copy link
Contributor

@RanJinh RanJinh commented Oct 30, 2024

What is the purpose of the change

To update the Testing Flink Jobs Docs example from deprecated SinkFunction to Sink.

Brief change log

  • Using Sink instead of SinkFunction, since SinkFunction is deprecated in flink 1.20.

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 30, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@@ -449,26 +449,41 @@ public class ExampleIntegrationTest {
CollectSink.values.clear();

// create a stream of custom elements and apply transformations
env.fromElements(1L, 21L, 22L)
env.fromData(1L, 21L, 22L)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is difficult to review without trying it. It would be great if this class or a variant was in Flink as a test class, with a comment to say if the class is changed then change the docs. In this way we should have a working test and valid docs.

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Chi on 12/12/24. Asked submitter questions

@RanJinh RanJinh force-pushed the testing-Doc branch 2 times, most recently from 99a504d to 02da917 Compare January 26, 2025 07:30
@RanJinh
Copy link
Contributor Author

RanJinh commented Feb 5, 2025

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants