-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager #25607
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1bb2658
to
72ee293
Compare
@qiaqialuguo CI is failing. |
@flinkbot run azure |
@qiaqialuguo CI is failing - maybe a rebase might help? Failing that raise a CI issue - as it seems unrelated to your change. |
Reviewed by Chi on 05/12/24. Asked submitter questions . sorting out the CI test then LGTM |
@flinkbot run azure |
Thanks for the suggestion, @davidradl! Rebase was helpful. |
What is the purpose of the change
This pull request corrects an inaccurate translation in the documentation regarding the role of JobMaster in Flink's architecture. The current documentation implies that JobManager supervises the execution of individual tasks, whereas it is actually the JobMaster, as a component within the JobManager, that is responsible for overseeing the execution of tasks for a single job.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation