Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager #25607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qiaqialuguo
Copy link

What is the purpose of the change

This pull request corrects an inaccurate translation in the documentation regarding the role of JobMaster in Flink's architecture. The current documentation implies that JobManager supervises the execution of individual tasks, whereas it is actually the JobMaster, as a component within the JobManager, that is responsible for overseeing the execution of tasks for a single job.

Brief change log

  • Updated the documentation to clarify that the JobMaster supervises the tasks for a single job, rather than implying that the JobManager itself manages each task.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@qiaqialuguo qiaqialuguo changed the title [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager Nov 5, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 5, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaqialuguo qiaqialuguo force-pushed the master branch 3 times, most recently from 1bb2658 to 72ee293 Compare November 12, 2024 15:48
@davidradl
Copy link
Contributor

@qiaqialuguo CI is failing.

@qiaqialuguo
Copy link
Author

@flinkbot run azure

@davidradl
Copy link
Contributor

@qiaqialuguo CI is failing - maybe a rebase might help? Failing that raise a CI issue - as it seems unrelated to your change.

@davidradl
Copy link
Contributor

Reviewed by Chi on 05/12/24. Asked submitter questions . sorting out the CI test then LGTM

@qiaqialuguo
Copy link
Author

@flinkbot run azure

@qiaqialuguo
Copy link
Author

qiaqialuguo commented Dec 6, 2024

@qiaqialuguo CI is failing - maybe a rebase might help? Failing that raise a CI issue - as it seems unrelated to your change.

Thanks for the suggestion, @davidradl! Rebase was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants