Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo from MARCO to MACRO #25614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typo from MARCO to MACRO #25614

wants to merge 2 commits into from

Conversation

sim-pez
Copy link

@sim-pez sim-pez commented Nov 6, 2024

Fix MARCO to MACRO

Fix MARCO to MACRO
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@@ -27,7 +27,7 @@ With Hive dialect, the following CREATE statements are supported for now:
- CREATE DATABASE
- CREATE TABLE
- CREATE VIEW
- CREATE MARCO
- CREATE MACRO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - could you correct the Chinese versions and the instances in drop.md as well please.

@sim-pez
Copy link
Author

sim-pez commented Nov 20, 2024

Hi @davidradl, thank you for your feedback. I’ve pushed again to fix all the typos I found.

@davidradl
Copy link
Contributor

Thanks for your contribution @sim-pez.

Can you please rename PR/commit in order to follow guide
https://flink.apache.org/how-to-contribute/reviewing-prs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants