Skip to content

[FLINK-37730][rest] Add client method for getting JM exception history #26525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vsantwana
Copy link

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

This PR is a part of a bigger change in Flink Kubernetes Operator. As outline in this JIRA ticket, the idea is to expose the Job Manager Exceptions as Kubernetes Events.

This PR adds an API method to the RestClusterClient which will be then used in the operator's reconciler to keep a track of the exceptions.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact

  • Deployments RPC transmits only the blob storage reference

  • TaskManagers retrieve the TaskInfo from the blob cache

  • RestClusterClient exposes method getJobExceptions given a JobID.

  • This is unit tested in RestClusterClientTest

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented May 2, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@vsantwana
Copy link
Author

@flinkbot run azure

* @param jobID The job id
* @return Job exceptions
*/
public CompletableFuture<JobExceptionsInfoWithHistory> getJobExceptions(JobID jobID) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious what happens if there are loops / repeated exceptions - will this cause an issue with the rest call. Is there a case to have a paging API here to avoid large responses?

@rmetzger
Copy link
Contributor

rmetzger commented May 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants