-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[FLINK-37790][4/N] introduce model provider related interfaces #26577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaosky
commented
May 20, 2025
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java
Outdated
Show resolved
Hide resolved
fsk119
reviewed
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left some comments
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java
Outdated
Show resolved
Hide resolved
...able/flink-table-common/src/main/java/org/apache/flink/table/connector/ml/ModelProvider.java
Outdated
Show resolved
Hide resolved
.../flink-table-common/src/main/java/org/apache/flink/table/functions/AsyncPredictFunction.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/module/Module.java
Outdated
Show resolved
Hide resolved
davidradl
reviewed
May 20, 2025
...table/flink-table-common/src/main/java/org/apache/flink/table/functions/PredictFunction.java
Outdated
Show resolved
Hide resolved
fsk119
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add model provider related interfaces proposed in https://cwiki.apache.org/confluence/display/FLINK/FLIP-525%3A+Model+ML_PREDICT%2C+ML_EVALUATE+Implementation+Design
Brief change log
Introduce following classes:
ModelProviderFactory
ModelProvider
PredictRuntimeProvider
AsyncPredictRuntimeProvider
PredictFunction
AsyncPredictFunction
Modified
Module
to addgetModelProviderFactory
Verifying this change
All new interfaces. Test will be added in following up PRs using these interfaces
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes)Documentation