-
Notifications
You must be signed in to change notification settings - Fork 255
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(java): ThreadLocalFury and ThreadPoolFury prioritize using the us…
…er classloader (#1907) ## What does this PR do? ThreadLocalFury and ThreadPoolFury prioritize using the user-specified ClassLoader <!-- Describe the purpose of this PR. --> ## Related issues [1884](#1884) [1878](#1878) <!-- Is there any related issue? Please attach here. - #xxxx0 - #xxxx1 - #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> --------- Co-authored-by: Shawn Yang <[email protected]>
- Loading branch information
1 parent
f6fdaeb
commit a45886e
Showing
3 changed files
with
87 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
java/fury-core/src/test/java/org/apache/fury/classloader/ThreadSafeFuryClassLoaderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.fury.classloader; | ||
|
||
import org.apache.fury.Fury; | ||
import org.apache.fury.ThreadSafeFury; | ||
import org.apache.fury.config.Language; | ||
import org.testng.Assert; | ||
import org.testng.annotations.Test; | ||
|
||
public class ThreadSafeFuryClassLoaderTest { | ||
|
||
static class MyClassLoader extends ClassLoader {} | ||
|
||
@Test | ||
void testFuryThreadLocalUseProvidedClassLoader() throws InterruptedException { | ||
final MyClassLoader myClassLoader = new MyClassLoader(); | ||
final ThreadSafeFury fury = | ||
Fury.builder() | ||
.withClassLoader(myClassLoader) | ||
.withLanguage(Language.JAVA) | ||
.requireClassRegistration(false) | ||
.buildThreadLocalFury(); | ||
fury.setClassLoader(myClassLoader); | ||
|
||
Thread thread = | ||
new Thread( | ||
() -> { | ||
final ClassLoader t = fury.getClassLoader(); | ||
Assert.assertEquals(t, myClassLoader); | ||
}); | ||
thread.start(); | ||
thread.join(); | ||
} | ||
|
||
@Test | ||
void testFuryPoolUseProvidedClassLoader() throws InterruptedException { | ||
final MyClassLoader myClassLoader = new MyClassLoader(); | ||
final ThreadSafeFury fury = | ||
Fury.builder() | ||
.withClassLoader(myClassLoader) | ||
.withLanguage(Language.JAVA) | ||
.requireClassRegistration(false) | ||
.buildThreadSafeFuryPool(1, 1); | ||
fury.setClassLoader(myClassLoader); | ||
|
||
Thread thread = | ||
new Thread( | ||
() -> { | ||
final ClassLoader t = fury.getClassLoader(); | ||
Assert.assertEquals(t, myClassLoader); | ||
}); | ||
thread.start(); | ||
thread.join(); | ||
} | ||
} |