-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPREDUCE-7472. Decode value of hive.query.string for the job Confguration which was encoded by hive #6520
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
9035b9e
to
1cbc995
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not the right way to do such things, we can't hardcode a hive conf in the MR code.
The correct way would be to introduce a config which can take a csv with a set of configs which should be decoded for UI and from Hive we can set that conf to have hive.query.string.
💔 -1 overall
This message was automatically generated. |
@ayushtkn patch updated, thanks for your suggestion . |
💔 -1 overall
This message was automatically generated. |
3f3f9ff
to
45f51df
Compare
add UT for the pr |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…hive,such as hive.query.string
d5e7654
to
de49c49
Compare
fix checkstyle of WhitespaceAfter,another one :'method call' child has incorrect indentation level 10 ,is legacy code |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
the value of hive.query.string in job Configuratio is URLEncoded by hive and written to hdfs,which shoud be decoded before rendered