-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19057. S3A: Landsat bucket used in tests no longer accessible (#6515) #6548
Merged
steveloughran
merged 2 commits into
apache:branch-3.3
from
steveloughran:s3/HADOOP-19057-landsat-replacement-branch-3.3
Feb 14, 2024
Merged
HADOOP-19057. S3A: Landsat bucket used in tests no longer accessible (#6515) #6548
steveloughran
merged 2 commits into
apache:branch-3.3
from
steveloughran:s3/HADOOP-19057-landsat-replacement-branch-3.3
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#6515) The AWS landsat data previously used in some S3A tests is no longer accessible This PR moves to the new external file s3a://noaa-cors-pds/raw/2024/001/akse/AKSE001x.24_.gz * Large enough file for scale tests * Bucket supports anonymous access * Ends in .gz to keep codec tests happy * No spaces in path to keep bucket-info happy Test Code Changes * Leaves the test key name alone: fs.s3a.scale.test.csvfile * Rename all methods and fields move remove "csv" from their names and move to "external file" we no longer require it to be CSV. * Path definition and helper methods have been moved to PublicDatasetTestUtils * Improve error reporting in ITestS3AInputStreamPerformance if the file is too short This is the V1 SDK version of the patch; it has deleted ITestAWSStatisticCollection as part of the changes. With S3 Select removed, there is no need for the file to be a CSV file; there is a test which tries to unzip it; other tests have a minimum file size. Consult the JIRA for the settings to add to auth-keys.xml to switch earlier builds to this same file. Contributed by Steve Loughran Change-Id: I0a2222f25b783e3b8f4935a60cdff788227c376f
this is the cherrypick of #6515 to branch-3.3, moving to the v1 sdk. a couple of places I left the variables as csvPath as is simplified the test, cut some methods and a whole test suite as they were obsolete and not worth reworking. All tests which weren't skipped passed |
🎊 +1 overall
This message was automatically generated. |
Change-Id: Iae057ec3db8e2a1de29de487d1925e6aaf608575
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS landsat data previously used in some S3A tests is no longer accessible
This PR moves to the new external file
s3a://noaa-cors-pds/raw/2024/001/akse/AKSE001x.24_.gz
Test Code Changes
This is the V1 SDK version of the patch; it has deleted ITestAWSStatisticCollection as part of the changes.
With S3 Select removed, there is no need for the file to be a CSV file; there is a test which tries to unzip it; other tests have a minimum file size.
Consult the JIRA for the settings to add to auth-keys.xml to switch earlier builds to this same file.
Contributed by Steve Loughran
How was this patch tested?
s3 london
-Dparallel-tests -DtestsThreadCount=8 -Dscale
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?