HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ayushtkn
changed the title
ayushtkn
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
fyi you'll need to update LICENSE-binary too; references hbase 1 artifacts |
|
💔 -1 overall
This message was automatically generated. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanx I have update the LICENSE-binary file, the Jenkins warnings aren't related to my change. I will track them separately |
|
💔 -1 overall
This message was automatically generated. |
|
license warnings are due to vm crash logs something not launching right? |
|
The license thing was was green till here: But in this I fixed a RBF build failure, considering it broke by my changes, later it got committed separately, so I had to rebase & force-push same changes + changes in LICENSE & building.txt file. I don’t think it is related to patch. I will rebase again & see |
|
💔 -1 overall
This message was automatically generated. |
|
looks like some launched process is crashing leaving a .log file... |
|
vm-crash.txt This test doesn't create issues locally though, I will find some time & explore what could be a potential fix |
…iling with NoClassDefFoundError. Contributed by Sushil Ks." This reverts commit eeaf8ed.
|
Spent some time over the weekend to investigate this, findings so far
TLDR: If we get a green build, We are sorted, Else I have another fix as well. Which has already given me a green build on my Test PR, I will investigate more over the weekend & move to it if this one fails. |
|
💔 -1 overall
This message was automatically generated. |
|
The test failures doesn't look related. With same change on my Test PR different tests failed, the VM crashing and stuff is sorted, ASF License is green. |
| @@ -27,22 +27,14 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
|
|
|||
| <artifactId>hadoop-yarn-server-timelineservice-hbase-server-2</artifactId> | |||
| <name>Apache Hadoop YARN TimelineService HBase Server 2.2</name> | |||
| <name>Apache Hadoop YARN TimelineService HBase Server 2.5.8</name> | |||
There was a problem hiding this comment.
better to keep as 2.5?
vinayakumarb
approved these changes
Apr 15, 2024
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Apr 16, 2024
...roject/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
The test failure isn't related, We already have HDFS-17224 for that test, though that mentions only one test from that class, but it is the same thing. I can trigger the build again to get a green build, if required |
|
whats up with pathlen? some relic of windows API era? does it still cause problems? |
|
Not sure what is the reason for having this, but should be Windows thing I believe, our Building.txt talks about path in case of Windows But in current context, It is talking about the files I deleted. Since I dropped the entire HBase v1 module The names have This module itself we deleted here This is the link from our daily build for pathlen, you can check all these files are there You can try searching |
steveloughran
approved these changes
Apr 22, 2024
CCweixiao
pushed a commit
to CCweixiao/hadoop
that referenced
this pull request
May 4, 2024
…). Contributed by Ayush Saxena
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Aug 29, 2024
…). Contributed by Ayush Saxena Change-Id: I438d089be9d25cf48eea61c488467094f893c6a6
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Aug 29, 2024
…). Contributed by Ayush Saxena Change-Id: I438d089be9d25cf48eea61c488467094f893c6a6
4 tasks
steveloughran
added a commit
that referenced
this pull request
Oct 9, 2024
…ase v2 (#6629). (#7017) This removes support for HBase 1 in the timeline service, moving to an up-to-date HBase 2 version instead. This does not affect the ability of HBase 1 to run on this version of Hadoop -it just removes it from our own redistributables, along with all copies of protobuf-2.5 Contributed by Ayush Saxena
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Drop support for Hbase v1 & Upgrade Hbase v2
How was this patch tested?
Jenikins
For code changes: