YARN-11387. [GPG] YARN GPG mistakenly deleted applicationid. #6660
+104
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
commented
Mar 26, 2024
| @@ -46,47 +45,38 @@ public void run() { | |||
| LOG.info("Application cleaner run at time {}", now); | |||
|
|
|||
| FederationStateStoreFacade facade = getGPGContext().getStateStoreFacade(); | |||
There was a problem hiding this comment.
Step 1: Retrieve all applications stored in the StateStore, which represents all applications submitted to the Router.
Step 2: Use the Router's REST API to fetch all running tasks. This API will invoke applications from all active SubClusters.
Step 3: Compare the results of Step1 and Step2 to identify applications that exist in Step1 but not in Step2. Delete these applications.
There is a potential issue with this approach. If a particular SubCluster is undergoing maintenance, such as RM restart, Step2 will not be able to fetch the complete list of running applications. As a result, during the comparison in Step3, there is a risk of mistakenly deleting applications that are still running.
We have three SubClusters: subClusterA, subClusterB, and subClusterC, with an equal allocation ratio of 1:1:1.
We submit six applications through routerA.
app1 and app2 are allocated to subClusterA
app3 and app4 to subClusterB
app5 and app6 to subClusterC.
Among these, app1, app3, and app5 have completed their execution, and we expect to retain app2, app4, and app6 in the StateStore.
In the normal scenario:
Comparing the steps mentioned above:
Step 1: We will retrieve six applications [app1, app2, app3, app4, app5, app6] from the StateStore.
Step 2: We will fetch three applications [app2, app4, app6] from the Router's REST interface.
Step 3: By comparing Step 1 and Step 2, we can identify that applications [app1, app3, app5] should be deleted.
In the exceptional scenario:
Comparing the steps mentioned above:
Step 1: We will retrieve six applications [app1, app2, app3, app4, app5, app6] from the StateStore.
Step 2: We will fetch the list of running applications from the Router's REST interface. However, due to maintenance in subClusterB and subClusterC, we can only obtain the applications running in subClusterA [app2].
Step 3: By comparing Step 1 and Step 3, we can identify that applications [app1, app3, app4, app5, app6] should be deleted.
In this case, we had an error deletion.
|
@goiri Can you help review this PR? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this PR? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM. |
myandpr
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11387. [GPG] YARN GPG mistakenly deleted applicationid.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?