HADOOP-19135. Remove Jcache 1.0-alpha. #6695

slfan1989 · 2024-04-02T00:03:27Z

Description of PR

HADOOP-19135. Remove Jcache 1.0-alpha.

I tried to remove the dependency org.apache.geronimo.specs:geronimo-jcache_1.0_spec. This dependency has not been maintained for too long.

We can check the dependency status from the following link. The last maintenance was in 2014.
https://mvnrepository.com/artifact/org.apache.geronimo.specs/geronimo-jcache_1.0_spec.

I tried to remove this dependency directly, but when compiling, a new error appeared.

The compilation report is as follows:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/1/artifact/out/patch-mvnsite-root.txt

package javax.cache.integration does not exist

https://www.javadoc.io/static/javax.cache/cache-api/1.1.0/javax/cache/integration/CacheLoader.html

javax.cache is defined by the JSR107 standard, I will introduce new dependencies.

 <dependency>
     <groupId>javax.cache</groupId>
     <artifactId>cache-api</artifactId>
     <version>1.1.1</version>
 </dependency>

https://mvnrepository.com/artifact/javax.cache/cache-api/1.1.1

Local compilation has been successful.

How was this patch tested?

no need test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-04-02T08:08:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 42s		Maven dependency ordering for branch
+1 💚	mvninstall	32m 18s		trunk passed
+1 💚	compile	17m 28s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	16m 16s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	mvnsite	21m 29s		trunk passed
+1 💚	javadoc	8m 57s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	8m 1s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	shadedclient	49m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 25s	/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt	hadoop-yarn-server-common in the patch failed.
-1 ❌	mvninstall	4m 1s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	6m 59s	/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	javac	6m 59s	/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	compile	6m 43s	/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
-1 ❌	javac	6m 43s	/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-1 ❌	mvnsite	2m 38s	/patch-mvnsite-root.txt	root in the patch failed.
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	3m 23s	/patch-javadoc-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	javadoc	7m 52s	/results-javadoc-javadoc-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~~20.04-b06 with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~~20.04-b06 generated 1 new + 1444 unchanged - 0 fixed = 1445 total (was 1444)
-1 ❌	shadedclient	19m 58s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	282m 48s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 7s		The patch does not generate ASF License warnings.
		483m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/1/artifact/out/Dockerfile
GITHUB PR	#6695
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 64d5431d5df8 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a8a1f28`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/1/testReport/
Max. process+thread count	3980 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-04-02T08:11:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 39s		Maven dependency ordering for branch
+1 💚	mvninstall	32m 22s		trunk passed
+1 💚	compile	17m 7s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	15m 46s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	mvnsite	21m 59s		trunk passed
+1 💚	javadoc	8m 20s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	7m 44s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	shadedclient	49m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 25s	/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt	hadoop-yarn-server-common in the patch failed.
-1 ❌	mvninstall	3m 59s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	7m 45s	/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	javac	7m 45s	/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	compile	6m 51s	/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
-1 ❌	javac	6m 51s	/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-1 ❌	mvnsite	2m 46s	/patch-mvnsite-root.txt	root in the patch failed.
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	3m 42s	/patch-javadoc-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt	root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.
-1 ❌	javadoc	8m 17s	/results-javadoc-javadoc-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt	root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~~20.04-b06 with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~~20.04-b06 generated 1 new + 1444 unchanged - 0 fixed = 1445 total (was 1444)
-1 ❌	shadedclient	21m 12s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	283m 26s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		485m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/2/artifact/out/Dockerfile
GITHUB PR	#6695
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 335bb4b8e23d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a8a1f28`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/2/testReport/
Max. process+thread count	3875 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-04-05T02:35:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	23m 25s		Maven dependency ordering for branch
+1 💚	mvninstall	33m 11s		trunk passed
+1 💚	compile	17m 40s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	15m 56s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	mvnsite	27m 16s		trunk passed
+1 💚	javadoc	8m 50s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	7m 55s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	shadedclient	49m 37s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 37s		Maven dependency ordering for patch
+1 💚	mvninstall	30m 24s		the patch passed
+1 💚	compile	16m 54s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	16m 54s		the patch passed
+1 💚	compile	16m 19s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	javac	16m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	17m 12s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 39s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	7m 57s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	shadedclient	50m 35s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	767m 20s		root in the patch passed.
+1 💚	asflicense	1m 39s		The patch does not generate ASF License warnings.
		1075m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/3/artifact/out/Dockerfile
GITHUB PR	#6695
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 113ccad1973b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `190be76`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/3/testReport/
Max. process+thread count	4150 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6695/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2024-04-05T11:10:43Z

@goiri @steveloughran Can you help review this pr? Thank you very much!

steveloughran

LGTM
+1

merge at your leisure, backport to 3.4/3.3

slfan1989 · 2024-04-05T14:08:47Z

LGTM +1

merge at your leisure, backport to 3.4/3.3

Thank you for reviewing pr! I will backport pr to the branch-3.3/branch-3.4 branch.

…Fan. Reviewed-by: Steve Loughran <[email protected]> Signed-off-by: Shilun Fan <[email protected]>

HADOOP-19135. Remove Jcache 1.0-alpha.

3afbd84

github-actions bot added build trunk labels Apr 2, 2024

HADOOP-19135. Remove Jcache 1.0-alpha.

a8a1f28

github-actions bot added the YARN label Apr 2, 2024

slfan1989 marked this pull request as draft April 3, 2024 23:48

HADOOP-19135. Remove Jcache 1.0-alpha.

190be76

slfan1989 self-assigned this Apr 4, 2024

slfan1989 marked this pull request as ready for review April 4, 2024 08:38

steveloughran approved these changes Apr 5, 2024

View reviewed changes

slfan1989 merged commit a1ae35e into apache:trunk Apr 5, 2024
1 of 3 checks passed

slfan1989 added a commit that referenced this pull request Apr 7, 2024

HADOOP-19135. Remove Jcache 1.0-alpha. (#6695) Contributed by Shilun …

d02ca96

…Fan. Reviewed-by: Steve Loughran <[email protected]> Signed-off-by: Shilun Fan <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19135. Remove Jcache 1.0-alpha. #6695

HADOOP-19135. Remove Jcache 1.0-alpha. #6695

slfan1989 commented Apr 2, 2024 •

edited

Loading

hadoop-yetus commented Apr 2, 2024

hadoop-yetus commented Apr 2, 2024

hadoop-yetus commented Apr 5, 2024

slfan1989 commented Apr 5, 2024

steveloughran left a comment

slfan1989 commented Apr 5, 2024

HADOOP-19135. Remove Jcache 1.0-alpha. #6695

HADOOP-19135. Remove Jcache 1.0-alpha. #6695

Conversation

slfan1989 commented Apr 2, 2024 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Apr 2, 2024

hadoop-yetus commented Apr 2, 2024

hadoop-yetus commented Apr 5, 2024

slfan1989 commented Apr 5, 2024

steveloughran left a comment

Choose a reason for hiding this comment

slfan1989 commented Apr 5, 2024

slfan1989 commented Apr 2, 2024 •

edited

Loading