-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19661. Migrate CentOS 8 to Rocky Linux 8 in build env Dockerfile #7900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Looks like Yetus finds Dockerfile from the trunk branch instead of the PR branch, I'm not very familiar with this part. If the behavior is not easy to change, I'm afraid this PR must be committed first, then we will know what is going to happen.
|
@pan3793 Currently, Hadoop's Yetus performs the build twice: first with the trunk code, and then again after applying the patch. At this point, I’m not certain whether what you pointed out is actually an issue. @aajisaka @ayushtkn @GauthamBanasandra Could you please take a look at this issue? Thank you very much! |
Would you push the commit to a new branch and then create a test PR based on the branch to check Yetus is working fine? |
💔 -1 overall
This message was automatically generated. |
@aajisaka I don't have the permission to commit hadoop repo ... |
with the help of @slfan1989, branch ![]() @aajisaka do you have other suggestions? |
@pan3793 Although we can compile locally, there are some issues with Yetus, so I cannot confirm whether this PR will affect other team members' code submissions. I still need @aajisaka @GauthamBanasandra to help verify it. |
(!) A patch to the testing environment has been detected. |
💔 -1 overall
This message was automatically generated. |
I have to rename it back to workaround the @slfan1989 @aajisaka, please take a look, and ping me to revert the renaming change if you think it's ready to go. |
@pan3793 LGTM. I don't see any issues. I checked the compilation results and didn't find any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I'll commit this.
This reverts commit b2e0372.
💔 -1 overall
This message was automatically generated. |
@cnauroth I need to revert the renaming change before committing to trunk ... let me send a follow up to address it |
Description of PR
Rocky Linux is supposed to be a drop-in replacement for the discontinued CentOS. See more details at https://rockylinux.org/about
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?