Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28832 Fixed TestInfoServersACL test #6572

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Jan 6, 2025

There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

@PDavid
Copy link
Contributor Author

PDavid commented Jan 6, 2025

This is the same as #6571 but for branch-3.

@NihalJain
Copy link
Contributor

Hi @PDavid We are good to merge this? Right?

@PDavid
Copy link
Contributor Author

PDavid commented Jan 7, 2025

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,

Actually I wanted to wait for a green build but as far as I see, the PR build timed out.
Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

@PDavid PDavid force-pushed the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch from fcb227c to bcb4587 Compare January 7, 2025 08:24
@NihalJain
Copy link
Contributor

NihalJain commented Jan 7, 2025

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,

Actually I wanted to wait for a green build but as far as I see, the PR build timed out. Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

Sure let me re-trigger!

@NihalJain
Copy link
Contributor

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,
Actually I wanted to wait for a green build but as far as I see, the PR build timed out. Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

Sure let me re-trigger!

Oh I see already forced pushed, we are good then!

@PDavid PDavid marked this pull request as ready for review January 8, 2025 13:57
There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

(cherry picked from commit eba6a85)
@PDavid PDavid force-pushed the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch from bcb4587 to 9852363 Compare January 9, 2025 09:51
@PDavid
Copy link
Contributor Author

PDavid commented Jan 9, 2025

Rebased and force pushed again to trigger new build.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-3 Compile Tests _
+1 💚 mvninstall 4m 5s branch-3 passed
+1 💚 compile 4m 8s branch-3 passed
+1 💚 checkstyle 0m 40s branch-3 passed
+1 💚 spotbugs 1m 47s branch-3 passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 44s the patch passed
+1 💚 compile 3m 54s the patch passed
+1 💚 javac 3m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 59s the patch passed
+1 💚 spotbugs 2m 21s the patch passed
+1 💚 hadoopcheck 14m 33s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
46m 47s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6572
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux ca07d3daf08f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / 9852363
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Jan 9, 2025
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚 mvninstall 3m 5s branch-3 passed
+1 💚 compile 1m 0s branch-3 passed
+1 💚 javadoc 0m 30s branch-3 passed
+1 💚 shadedjars 5m 50s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 0m 54s the patch passed
+1 💚 javac 0m 54s the patch passed
+1 💚 javadoc 0m 26s the patch passed
+1 💚 shadedjars 5m 43s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 189m 19s hbase-server in the patch passed.
214m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6572
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4b4e91b9a073 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / 9852363
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/testReport/
Max. process+thread count 4795 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty merged commit 931b857 into apache:branch-3 Jan 15, 2025
1 check passed
@PDavid PDavid deleted the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch January 15, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants