-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-28909: Modify McolumnDescriptor definition in package.jdo to sup… #5804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port JDK17 + JDO6.0 For Hive to support JDK17 + JDO6.0, select/update/delete queries of the table are failing to fetch column information of the table. The DataNucleus6.0 is unable to map the Mcolumn Descriptor definition to the underlying table schema due to the presence of CLOB type field for the join condition in the package.jdo file. This patch addresses the issue by avoiding the CLOB column in the join condition.
bb52471
to
b968745
Compare
dengzhhu653
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 pending tests
deniskuzZ
reviewed
May 7, 2025
standalone-metastore/metastore-server/src/main/resources/datanucleus-log4j.properties
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 7, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 9, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 9, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 9, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java
Outdated
Show resolved
Hide resolved
5519df5
to
82bd967
Compare
deniskuzZ
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
deniskuzZ
reviewed
May 22, 2025
standalone-metastore/metastore-server/src/main/resources/package.jdo
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port JDK17 + JDO6.0
For Hive to support JDK17 + JDO6.0, select/update/delete queries of the table are failing to fetch column information of the table. The DataNucleus6.0 is unable to map the Mcolumn Descriptor definition to the underlying table schema due to the presence of CLOB type field for the join condition in the package.jdo file. This patch addresses the issue by avoiding the CLOB column in the join condition.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?