-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-24550 Port throttling metrics from AI2 #5392
Conversation
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
Show resolved
Hide resolved
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
Outdated
Show resolved
Hide resolved
/** | ||
* Metric source for persistent page memory. | ||
*/ | ||
public class PersistentPageMemoryMetricSource implements MetricSource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would ask you to indicate in the documentation for the fields that they are guarded by the monitor, otherwise I immediately notice bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise I immediately notice bugs.
What do you mean? What bugs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as I saw these fields, I thought there would be data races, until I looked at each method.
Do you think it might be worth using method synchronization instead of synchronization by internal mutex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I just did what all other implementations did :)
But I don't mind synchronizing on this
here, but if someone would insist, I'd fix it. I know that it is not a recommended practice
...g/apache/ignite/internal/pagememory/persistence/throttling/PagesWriteSpeedBasedThrottle.java
Outdated
Show resolved
Hide resolved
.../apache/ignite/internal/pagememory/persistence/throttling/TargetRatioPagesWriteThrottle.java
Outdated
Show resolved
Hide resolved
...ble/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ibessonov <[email protected]>
https://issues.apache.org/jira/browse/IGNITE-24550
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes