IGNITE-23110 Disallow IgniteCache#clear() within transaction #11559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishkovilja
suggested changes
Oct 23, 2024
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
Outdated
Show resolved
Hide resolved
J-Bakuli
force-pushed
the
ignite-23110
branch
from
683cdc2
to
03bbc2d
Compare
J-Bakuli
force-pushed
the
ignite-23110
branch
from
c4947bb
to
cb313f7
Compare
shishkovilja
approved these changes
Oct 30, 2024
J-Bakuli
force-pushed
the
ignite-23110
branch
from
e9de464
to
2fddaa7
Compare
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
J-Bakuli
changed the title
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/client/thin/BlockingTxOpsTest.java
Show resolved
Hide resolved
zstan
reviewed
Nov 19, 2024
...les/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheProxyImpl.java
Outdated
Show resolved
Hide resolved
|
plz remove commented code |
J-Bakuli
force-pushed
the
ignite-23110
branch
from
23566ce
to
d57c813
Compare
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java
Show resolved
Hide resolved
J-Bakuli
force-pushed
the
ignite-23110
branch
from
6d4ad87
to
e1a3a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IgniteCache#clearinvocation are not transactional.But, currently, Ignite allow to invoke
clearinside transaction.This lead to unexpected behaviour and hides business logic errors.
We must disallow IgniteCache#clear call inside transaction.
TCbot2
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.