IGNITE-23392 Add SessionContext API #11618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
f5d921f
to
8fa7e43
Compare
timoninmaxim
changed the title
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
fc2c340
to
1e2227d
Compare
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
1e2227d
to
40fa10d
Compare
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
2 times, most recently
from
207c370
to
d8bfe06
Compare
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
d8bfe06
to
6f33e04
Compare
nizhikov
reviewed
Nov 20, 2024
| @@ -221,6 +222,12 @@ private void dropTable(H2TableDescriptor tbl) { | |||
|
|
|||
| /** {@inheritDoc} */ | |||
| @Override public void onFunctionCreated(String schema, String name, boolean deterministic, Method method) { | |||
| if (!Modifier.isStatic(method.getModifiers())) { | |||
| log.warning("Skip creating SQL function '" + name + "' in H2 engine because it is not static."); | |||
There was a problem hiding this comment.
Let's use LT.warn here to reduce number of logging in case user application generates a lot of query with the same UDF.
There was a problem hiding this comment.
This log message appears only once, when cache is created.
nizhikov
reviewed
Nov 20, 2024
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| /** | ||
| * Provides access to attributes set with {@link Ignite#withApplicationAttributes}. |
There was a problem hiding this comment.
Let's extend javadoc with the explanation about attributes hierarchy.
There was a problem hiding this comment.
Let's add javadocs for hierarchy in patch for ticket IGNITE-23725
nizhikov
reviewed
Nov 20, 2024
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| /** | ||
| * Provides access to session context. |
There was a problem hiding this comment.
Let's extend javadoc with the explanation about attributes hierarchy.
There was a problem hiding this comment.
Let's add javadocs for hierarchy in patch for ticket IGNITE-23725
nizhikov
reviewed
Nov 20, 2024
modules/core/src/main/java/org/apache/ignite/internal/cache/context/SessionContextImpl.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Nov 20, 2024
modules/core/src/main/java/org/apache/ignite/cache/SessionContextProvider.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Nov 21, 2024
modules/core/src/main/java/org/apache/ignite/resources/SessionContextProviderResource.java
Show resolved
Hide resolved
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
9f2c3a4
to
cef71fa
Compare
timoninmaxim
force-pushed
the
IGNITE-23392__application_context_srv
branch
from
455f3c1
to
37b4965
Compare
nizhikov
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.