IGNITE-22733 Introduce TransactionChanges #11675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoninmaxim
requested changes
Nov 22, 2024
...c/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionChanges.java
Show resolved
Hide resolved
| * Sort new and updated entries collection. | ||
| * @param comparator Entries comparator | ||
| */ | ||
| public void sortNewAndUpdatedEntries(Comparator<E> comparator) { |
There was a problem hiding this comment.
Is it possible to specify comparator in constructor?
| for (TransactionConcurrency txConcurrency : TransactionConcurrency.values()) { | ||
| ExecutorType[] nodeExecTypes = {ExecutorType.SERVER, ExecutorType.CLIENT}; | ||
| ExecutorType[] thinExecTypes; | ||
|
|
||
| if (modify == SQL) { |
There was a problem hiding this comment.
Do we need this changes in this patch?
There was a problem hiding this comment.
The main reason to include test changes in patch is to reduce main patch.
Exclude obvious changes from it.
So I thins yes, we need this :)
| ); | ||
|
|
||
| txChanges.get2().sort(this::compare); | ||
| } | ||
| else | ||
| txChanges = null; |
There was a problem hiding this comment.
Can replace with TransactionChanges#EMPTY, it will done automatically in call ectx.transactionChanges. It will help to remove useless check for null in 254L.
timoninmaxim
approved these changes
Nov 25, 2024
luchnikovbsk
pushed a commit
to luchnikovbsk/ignite
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…test
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.