IGNITE-23745 SQL Calcite: Add ability to extend SQL engine with new system functions/operators #11684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem functions/operators
…ystem functions/operators (revert aggregates)
Vladsz83
reviewed
Nov 27, 2024
| } | ||
|
|
||
| @Override public void start(PluginContext ctx) { | ||
| IgniteOwnSqlOperatorTable.instance().register(SUBSTR); |
There was a problem hiding this comment.
If we want to extend a default operator, IgniteOwnSqlOperatorTable should go first in FrameworkConfig (CalciteQueryProcessor#FRAMEWORK_CONFIG). Otherwise, filtering operator overload by strict operands types isn't reliable. Operand types might not be consedered in SqlUtil#filterRoutinesByParameterTypeAndName()
Vladsz83
reviewed
Nov 27, 2024
| @@ -53,6 +54,16 @@ private IgniteConvertletTable() { | |||
| addAlias(IgniteOwnSqlOperatorTable.LENGTH, SqlStdOperatorTable.CHAR_LENGTH); | |||
| } | |||
|
|
|||
| /** {@inheritDoc} */ | |||
| @Override public void registerOp(SqlOperator op, SqlRexConvertlet convertlet) { | |||
| super.registerOp(op, convertlet); | |||
There was a problem hiding this comment.
If we want to extend a default operator, we should take in account overriding a default converter like StandardConvertletTable#convertPlus(..).
…ystem functions/operators
…ystem functions/operators
…ystem functions/operators
…ystem functions/operators
…ystem functions/operators
…ystem functions/operators
…ystem functions/operators
ivandasch
approved these changes
Dec 5, 2024
luchnikovbsk
pushed a commit
to luchnikovbsk/ignite
that referenced
this pull request
Jan 31, 2025
…ystem functions/operators - Fixes apache#11684. Signed-off-by: Aleksey Plekhanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.