Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maplibre to version 5 #53

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Update Maplibre to version 5 #53

merged 2 commits into from
Feb 17, 2025

Conversation

YongGoose
Copy link
Contributor

This PR updates the Maplibre library to version 5.0.1.

Related Issue : apache/incubator-baremaps#922

Copy link
Member

@bchapuis bchapuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested everything locally and the demonstration still works. Thank your for the upgrade.

@bchapuis
Copy link
Member

Apparently the build is more restrictive on the typescript types than the dev mode and we get a type error in the react component.

./src/components/map/index.tsx:84:9
Type error: Expected 2 arguments, but got 3.

  82 |         'https://unpkg.com/@mapbox/[email protected]/mapbox-gl-rtl-text.min.js',
  83 |         null,
> 84 |         true
     |         ^
  85 |       );
  86 |     }

@bchapuis bchapuis self-requested a review January 26, 2025 11:02
@YongGoose
Copy link
Contributor Author

Apparently the build is more restrictive on the typescript types than the dev mode and we get a type error in the react component.

Thank you for the detailed explanation!

@bchapuis
Copy link
Member

bchapuis commented Feb 17, 2025

@YongGoose Do you need more help to fix the build? Do not hesitate to reach out.

@YongGoose
Copy link
Contributor Author

@YongGoose Do you need more help to fix the build? Do not hesitate to reach out.

Oh my gosh! I completely forgot about this PR...
I'll try to resolve it myself first.

Thanks for the reminder! 🙇🏻‍♂️

@YongGoose
Copy link
Contributor Author

Apparently the build is more restrictive on the typescript types than the dev mode and we get a type error in the react component.

./src/components/map/index.tsx:84:9
Type error: Expected 2 arguments, but got 3.

  82 |         'https://unpkg.com/@mapbox/[email protected]/mapbox-gl-rtl-text.min.js',
  83 |         null,
> 84 |         true
     |         ^
  85 |       );
  86 |     }

Done in f959ad9 !

@bchapuis bchapuis merged commit 532cf37 into apache:main Feb 17, 2025
2 checks passed
@bchapuis
Copy link
Member

Merged! Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants