Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11287: Cleanup May Delete Referenced Segments #1880

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

OAK-11287: Cleanup May Delete Referenced Segments #1880

wants to merge 4 commits into from

Conversation

lweitzendorf
Copy link
Contributor

@lweitzendorf lweitzendorf commented Nov 28, 2024 •
edited
Loading

  • Fixes behavior of CleanupFirstGarbageCollectionStrategy
    • will no longer skip cleanup if compactFull or compactTail are called directly instead of from within run
    • now subclasses DefaultGarbageCollectionStrategy, which made AbstractGarbageCollectionStrategy obsolete
  • Changes GCJournal persistence behavior
    • any compaction result that alters the repository root will add an entry to the journal
  • Adds basic sanity check to the compacted root retrieval
    • cleanup is skipped if the entry's GC generation doesn't match the current repository head
    • prevents potential data loss in case of missing GC journal entries
  • Minor interface changes and typo fixes

@lweitzendorf lweitzendorf marked this pull request as ready for review November 28, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lweitzendorf