Skip to content

KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group #19796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group #19796

wants to merge 5 commits into from

Conversation

FrankYang0529
Copy link
Member

@FrankYang0529 FrankYang0529 commented May 23, 2025 •
edited by github-actions bot
Loading

  • Use metadata hash to replace subscription metadata.
  • Remove ShareGroupPartitionMetadataKey and
    ShareGroupPartitionMetadataValue.
  • Use subscriptionTopicNames and metadataImage to replace
    subscriptionMetadata in subscribedTopicsChangeMap function.

@github-actions github-actions bot added the tools label May 23, 2025
@FrankYang0529
fix failed test case
4fd9bc4 
Signed-off-by: PoAn Yang <[email protected]>
@github-actions github-actions bot added the core Kafka Broker label May 24, 2025
@FrankYang0529 FrankYang0529 changed the title KAFKA-17747: Replace subscription metadata with metadata hash in share group (wip) KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group May 24, 2025
@dajac
Copy link
Member

dajac commented May 26, 2025

This one should basically be a copy of #19761. Let's merge that one first and then we can review this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewJSchofield AndrewJSchofield Awaiting requested review from AndrewJSchofield

@dajac dajac Awaiting requested review from dajac

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core Kafka Broker tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYang0529 @dajac