KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] #19808
+203
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce doesn't exist message Signed-off-by: PoAn Yang <[email protected]>
DL1231
reviewed
May 26, 2025
| .map(name -> new ConfigResource(entry.getKey(), name))) | ||
| .collect(Collectors.toList()); | ||
| return new ListConfigResourcesResult(KafkaFuture.completedFuture(resources)); | ||
|
|
| return | ||
| } | ||
| case ClientMetricsType => | ||
| if (adminClient.listConfigResources(java.util.Set.of(ConfigResource.Type.CLIENT_METRICS), new ListConfigResourcesOptions).all.get |
There was a problem hiding this comment.
nit: Can't this just be util.Set.of?
There was a problem hiding this comment.
I prefer to leave this as java.util.xxx because we already used this pattern like:
We can do some refactor for Scala code in core module after this PR. Or we can refactor it when migrating to Java eventually.
| } | ||
| case GroupType => | ||
| if (adminClient.listGroups().all.get.stream.noneMatch(_.groupId() == name) && | ||
| adminClient.listConfigResources(java.util.Set.of(ConfigResource.Type.GROUP), new ListConfigResourcesOptions).all.get |
Signed-off-by: PoAn Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-existent resource in kafka-configs.sh and kafka-client-metrics.sh.
non-existent groups but having dynamic config. If it cannot find a group
in both conditions, return resource doesn't exist message.