-
Notifications
You must be signed in to change notification settings - Fork 14.6k
KAFKA-19616: Add compression type and level support to LogCompactionTester #20396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-19616: Add compression type and level support to LogCompactionTester #20396
Conversation
e2e test result
|
@yunchipang Could you please fix the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang: Please apply spotless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang thanks for your patch!
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang thanks for the updates!
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
e2e test result
|
running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang thanks for your updates
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
the failed test is already fixed by #20419 |
issue: KAFKA-19616
why: validate log compaction works correctly with compressed data.
what: adds compression config options to
LogCompactionTester
tooland extends test coverage to validate log compaction with different
compression types and levels.
Reviewers: TengYao Chi [email protected], Chia-Ping Tsai
[email protected]