Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tdigest): add tdigest algorithm and storage encoding implementations #2741
feat(tdigest): add tdigest algorithm and storage encoding implementations #2741
Changes from 22 commits
3ca2216
94d89c6
10527f1
5b62c77
b8f568f
675c815
d26ffeb
a462b07
f9b24b9
9d54b3d
ac5d7dd
067766f
2e22834
1b6a18a
da69aa9
b3a6370
303a4aa
d80a98f
32dc695
ac2ea2d
d79074e
aa24799
f84f7d3
592da56
7648868
1cb7eb6
d6817d3
91c760a
5a98607
9d7230b
f7fe96e
c4f9554
af5480b
9441342
7f6d090
0a6ae83
c23f106
f0f2f3d
0e842bb
1cb9882
5b56e16
d4f1a7c
a3f6713
79977a4
a39196f
baaf561
75c0361
ef1df05
f1c736d
c6699c8
84e0d43
52837bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would 64bits too large for compression argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mapleFU ,
Thanks for your advice! 😊
I have updated compression and capacity to
uint32_t
.Best Regards,
Edward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid init double via this way is not a good way, what about just min max?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mapleFU ,
Got it! 😊
I have updated with
max
andlowest
.Best Regards,
Edward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So statisitics like
merge_times
andtotal_observations
is also serialized, do they used forINFO
output or just for debugging?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mapleFU ,
These two metrics are used in
INFO
command for compatibility with redis.Best Regards,
Edward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a comment for that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mapleFU ,
Got it!
I have added comments for these two properties.
Best Regards,
Edward