Skip to content

chore(log): add unreachable() based on the current logging infra #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

chore(log): add unreachable() based on the current logging infra #2893

merged 1 commit into from
Apr 21, 2025

Conversation

PragmaTwice
Copy link
Member

Now we can use unreachable() instead of assert(false) or CHECK(false) to represent an unreachable point.

@PragmaTwice PragmaTwice merged commit 5f8e94b into apache:unstable Apr 21, 2025
33 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
59.6% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@git-hulk git-hulk Awaiting requested review from git-hulk

@torwig torwig Awaiting requested review from torwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @mapleFU