-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #4424][REST] Catch No Node Exception, when list kyuubi engines #4425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4425 +/- ##
============================================
- Coverage 53.20% 53.17% -0.04%
Complexity 13 13
============================================
Files 569 569
Lines 31055 31084 +29
Branches 4194 4196 +2
============================================
+ Hits 16522 16528 +6
- Misses 12973 12993 +20
- Partials 1560 1563 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Shall we check if engine spec is existed first and return a user-friendly exception ? e.g. |
This api used for list all engine under namespace or subdomain. It‘s reasonable if we return an empty list while simple namespace (like Probably not described clearly in desc, |
@ulysses-you Throw user-friendly exception when namespace node not created. |
thanks, merging to master |
…engines ### _Why are the changes needed?_ Close apache#4424 Catch No Node Exception, when list kyuubi engines ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request ![WX20230227-184957](https://user-images.githubusercontent.com/52876270/221544376-2f0d6b4b-0bc4-446e-abb1-d0c79211aea4.png) Closes apache#4425 from zwangsheng/kyuubi-4424. Closes apache#4424 3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style 74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception 7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException 4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines Authored-by: zwangsheng <[email protected]> Signed-off-by: ulyssesyou <[email protected]>
…engines ### _Why are the changes needed?_ Close apache#4424 Catch No Node Exception, when list kyuubi engines ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request ![WX20230227-184957](https://user-images.githubusercontent.com/52876270/221544376-2f0d6b4b-0bc4-446e-abb1-d0c79211aea4.png) Closes apache#4425 from zwangsheng/kyuubi-4424. Closes apache#4424 3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style 74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception 7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException 4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines Authored-by: zwangsheng <[email protected]> Signed-off-by: ulyssesyou <[email protected]>
Why are the changes needed?
Close #4424
Catch No Node Exception, when list kyuubi engines
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request