[KYUUBI #7136] Support more test cases about iceberg ranger check #7137
+381
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Jul 13, 2025
...la/org/apache/kyuubi/plugin/spark/authz/ranger/IcebergCatalogRangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
changed the title
pan3793
approved these changes
Jul 13, 2025
pan3793
reviewed
Jul 13, 2025
...la/org/apache/kyuubi/plugin/spark/authz/ranger/IcebergCatalogRangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Jul 13, 2025
...la/org/apache/kyuubi/plugin/spark/authz/ranger/IcebergCatalogRangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Cheng Pan <[email protected]>
|
@davidyuan1223 @pan3793 @nqvuong1998 @yaooqinn Can we merge this? |
No，there are some questions, i will check and fix this weekend |
|
Hi @davidyuan1223 @yaooqinn , Can we continue to able to merge this MR? |
|
Hi @davidyuan1223, any new update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Improve test cases could complete all command
How was this patch tested?
see #7136
Additional
Currently, Kyuubi's iceberg dependecy could not support Table Statistics. But i also add the test cases, just notes them, if we update the iceberg version, could use the test cases
Was this patch authored or co-authored using generative AI tooling?
No