fix: Fix Java type for annotated array parameters #3797
Merged
+81
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the GraalVM reachability metadata generation for methods with annotated array parameters, such as `@Nullable String[]`. Previously, the code computed the fully qualified class name for the parameter using the **raw** type, which retained the annotations (e.g., `@org.jspecify.annotations.Nullable java.lang.String`). This resulted in incorrect metadata that was ignored by GraalVM. The issue is resolved by transforming the `DeclaredType` into a `TypeElement`, effectively removing any annotations, and then calling `getQualifiedName()` to correctly generate the fully qualified class name without annotations.
vy
approved these changes
Jul 3, 2025
When compiling with JDK 8 an "unknown enum constant java.lang.annotation.ElementType.MODULE" warning appears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the GraalVM reachability metadata generation for methods with annotated array parameters, such as
@Nullable String[].Previously, the code computed the fully qualified class name for the parameter using the raw type, which retained the annotations (e.g.,
@org.jspecify.annotations.Nullable java.lang.String). This resulted in incorrect metadata that was ignored by GraalVM.The issue is resolved by transforming the
DeclaredTypeinto aTypeElement, effectively removing any annotations, and then callinggetQualifiedName()to correctly generate the fully qualified class name without annotations.Closes #3796