SOLR-15187: v2-POJO based SolrRequest classes #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2021 11:26
This commit starts to have the Payload POJOs replace the fields in individual CollectionAdminRequest classes. Backup is pretty much finished. I started on REstore and ran into a hiccup with the collection-creation params - I could handle these via map operations, but that's not very clean or strongly typed. So my next step needs to be creating a class that CreatePayload and REstorePayload can share with various collection-creation params.
This eliminates some duplication between the API-specific classes, provides an extra prod to make sure devs keep V2 APIs up to date, and gives us a path forward for v1-v2 randomization on POJO-based v2 APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The POJOs used for serialization/deserialization by some V2 APIs have a lot of duplication with the existing SolrRequest objects for those APIs.
Solution
Since they share the same fields, SolrRequest objects can be implemented using their v2-POJO counterparts.
Tests
None, yet.
Checklist
Please review the following and check all that apply:
masterbranch../gradlew check.