Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the query cache by default. #14187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Disable the query cache by default. #14187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c95a7f
Disable the query cache by default.
jpountz Jan 30, 2025
ba31600
CHANGES
jpountz Jan 30, 2025
5473eb5
iter
jpountz Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ Bug Fixes

* GITHUB#14075: Remove duplicate and add missing entry on brazilian portuguese stopwords list. (Arthur Caccavo)

Changes in Runtime Behavior
---------------------
* GITHUB#14187: The query cache is now disabled by default. (Adrien Grand)

Other
---------------------
(No changes)
Expand Down
10 changes: 2 additions & 8 deletions lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
public class IndexSearcher {

static int maxClauseCount = 1024;
private static QueryCache DEFAULT_QUERY_CACHE;
// Caching is disabled by default.
private static QueryCache DEFAULT_QUERY_CACHE = null;
private static QueryCachingPolicy DEFAULT_CACHING_POLICY = new UsageTrackingQueryCachingPolicy();
private QueryTimeout queryTimeout = null;
// partialResult may be set on one of the threads of the executor. It may be correct to not make
Expand All @@ -86,13 +87,6 @@ public class IndexSearcher {
// shouldn't hurt either.
private volatile boolean partialResult = false;

static {
final int maxCachedQueries = 1000;
// min of 32MB or 5% of the heap size
final long maxRamBytesUsed = Math.min(1L << 25, Runtime.getRuntime().maxMemory() / 20);
DEFAULT_QUERY_CACHE = new LRUQueryCache(maxCachedQueries, maxRamBytesUsed);
}

/**
* By default, we count hits accurately up to 1000. This makes sure that we don't spend most time
* on computing hit counts
Expand Down