Reusing count() for minor refactor in SortedNumericDocValuesRangeQuery #15123
Conversation
Signed-off-by: Ankit Jain <[email protected]>
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
jainankitk
added
the
skip-changelog
|
Javadocs of |
|
That's a good point. I was initially thinking of doing that by adding |
Signed-off-by: Ankit Jain <[email protected]>
| /* Returning 1 instead of LeafReader#numDocs as it may run in O(maxDoc) | ||
| * which is unnecessary when docCount is invoked from ScorerSupplier | ||
| */ | ||
| private int docCount(LeafReaderContext context) throws IOException { |
There was a problem hiding this comment.
I wonder if calling it docCountIgnoringDeletes and returning maxDoc instead of 1 would make the contract of this method a bit less awkward?
#15123) --------- Signed-off-by: Ankit Jain <[email protected]>
Description
Reusing count() for minor refactor in SortedNumericDocValuesRangeQuery