[MDEP-976] Fix artifact overwrites in copy-dependencies #523
Conversation
|
@Ndacyayisenga-droid please take time to review the checkboxes in the issue description and fill them as necessary: keeping them not checked is not useful on adding a new option just for copy-dependencies, I'm not clear: why? I'd prefer either we change the default value for |
|
notice: IIUC, the conflict happens only when stripVersion is enable, isn't it? WDYT of this behaviour poposal? |
|
@hboutemy It's possible for two different artifacts to have the same artifactId and version even though their groupId is different, isn't it? |
@hboutemy this might cause a lot of build failures, especially in cases where two different artifacts share the same artifactId. I tried to reproduce the issue in this projecct https://github.com/Ndacyayisenga-droid/mdep-976 (just execute the script). results For my snapshot |
elharo
changed the title
|
It absolutely is valid in Maven for two different artifacts to have the same artifact ID but different group IDs. Artifact IDs are not unique or intended to be. In fact, this is common with forked projects and likely occurs with other common artifact IDs like "utils". |
There was a problem hiding this comment.
"I'd prefer either we change the default value for prependGroupId, or we add code to detect when conflict happens and WARN with a hint on how to configure prependGroupId"
I suggest doing both, but let's not overly complexify things by adding another knob to twiddle.
Signed-off-by: Ndacyayisenga-droid <[email protected]>
| @@ -105,6 +105,15 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo { | |||
| @Parameter(property = "mdep.copySignatures", defaultValue = "false") | |||
| protected boolean copySignatures; | |||
|
|
|||
| /** | |||
| * Prepend the groupId to the output filename by default to avoid conflicts when artifactIds are not globally unique. | |||
| * Set to false to retain the original behavior. | |||
There was a problem hiding this comment.
It might be unclear to readers what the original behavior was.
| @@ -144,25 +153,27 @@ protected void doExecute() throws MojoExecutionException { | |||
| DependencyStatusSets dss = getDependencySets(this.failOnMissingClassifierArtifact, addParentPoms); | |||
| Set<Artifact> artifacts = dss.getResolvedDependencies(); | |||
|
|
|||
| boolean effectivePrependGroupId = prependGroupId || prependGroupIdByDefault; | |||
There was a problem hiding this comment.
why do we need both? One feels like it should be enough
Fixes https://issues.apache.org/jira/browse/MDEP-976
cc @hboutemy
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MDEP-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.