[#502] - Add prefix to zip entries

[YaSuenag]

I would like to introduce zipDirPrefix to add prefix to zip entries. See #502 for details.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a GitHub issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a GitHub issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [#<num>] - Fixes bug in ApproximateQuantiles,
  where you replace #<num> with the appropriate GitHub issue. Best practice
  is to use the GitHub issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[elharo]

I'm not sure, but is there any way you could add an integration test that actually runs a jlinked image with a prefix?

[YaSuenag]

@elharo
Thanks for your review!

I updated testcase to extract ZIP which contains prefix, and execute the launcher. It works fine on Linux, but it might not work on Windows because the ZIP would be extracted by unzip utility. It might be better if we can run this test on Linux only, but I don't know how should I configure that.

[YaSuenag]

All of tests on Windows were hanged due to new tests for this PR. I think the cause of the hang is unzip command is unavailable on Windows GHA runner or the test did not add extention (.bat) in Windows.

I tweaked a testcase in the latest commit, and it works fine on both Ubuntu 24 and Windows 11. Could you approve to run the workflow? I believe it works fine.

[bmarwell]

Except for docs, looks good to me.

[bmarwell]

I think this comment needs clarification, as it goes into the docs (site).

• If it does not end with /, what will happen?
• Isn't the prefix always supposed to be a directory?
• What does the default do (explain to users)?

[YaSuenag]

Isn't the prefix always supposed to be a directory?

Yes, I think so because if the prefix does not have "/" in its tail, it breaks JDK directory structure - it means any launcher and java command in bin directory would not work. I will fix, and clarify Javadoc.

[YaSuenag]

@bmarwell
I fixed docs, and always treats this value as a directory. Could you review again?

[bmarwell]

Probably doesn't matter, but maybe we can find another example module

[YaSuenag]

Can you explain details of your comment?

This testcase creates launcher as following:

<launcher>helloworld=com.corporate.project/com.corporate.project.HelloWorld</launcher>

I think the app should be modulalized for --launcher option in jlink. So I think module-info.java is necessary for this test.

[YaSuenag]

Do you have any comments?
I believe this feature is useful for developers who want to package artifacts in jlink phase at once.

Comments are welcome. I can work for them if needs.