-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2370 Add support for parameter providers #1895
Open
lordgamez
wants to merge
4
commits into
apache:MINIFICPP-2376
Choose a base branch
from
lordgamez:MINIFICPP-2370
base: MINIFICPP-2376
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-2370
branch
2 times, most recently
from
November 14, 2024 15:35
3654aae
to
0d9b7b4
Compare
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
November 20, 2024 09:14
0d9b7b4
to
4deae19
Compare
lordgamez
force-pushed
the
MINIFICPP-2376
branch
from
November 22, 2024 13:26
54a69d0
to
a29feb9
Compare
- Add EnvironmentVariableParameterProvider
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
November 22, 2024 13:38
4deae19
to
2f34533
Compare
fgerlits
reviewed
Jan 13, 2025
libminifi/src/parameter-providers/EnvironmentVariableParameterProvider.cpp
Outdated
Show resolved
Hide resolved
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
January 15, 2025 08:42
1c0186a
to
7c8f3cc
Compare
fgerlits
reviewed
Jan 15, 2025
fgerlits
reviewed
Jan 15, 2025
fgerlits
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1888
https://issues.apache.org/jira/browse/MINIFICPP-2370
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.