MINIFICPP-2509 Add option to reload parameter contexts from parameter providers on restart #1915
Conversation
lordgamez
force-pushed
the
MINIFICPP-2509
branch
from
d448c1c to
79db83c
Compare
|
I think if reload is true, we shouldn't even write out the parameters to the flow definition |
I'm not sure it's a good idea, we should be able to see the parameters in the flow definition. It's useful for the user to see what parameters are used in the flow configuration in runtime and can be useful for debugging purposes as well. |
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
efe1fd8 to
2228878
Compare
… providers on restart
lordgamez
force-pushed
the
MINIFICPP-2509
branch
from
79db83c to
d05f3e7
Compare
| @@ -65,16 +65,23 @@ class ParameterProvider : public ConfigurableComponentImpl, public CoreComponent | |||
| MINIFIAPI static constexpr auto SensitiveParameterList = core::PropertyDefinitionBuilder<>::createProperty("Sensitive Parameter List") | |||
| .withDescription("List of sensitive parameters, if 'Sensitive Parameter Scope' is set to 'selected'.") | |||
| .build(); | |||
| MINIFIAPI static constexpr auto ReloadValuesOnRestart = core::PropertyDefinitionBuilder<>::createProperty("Reload Values On Restart") | |||
| .withDescription("Reload provider generated parameter context values on restart") | |||
There was a problem hiding this comment.
minor improvement (add hyphen, clarify what 'restart' means):
| .withDescription("Reload provider generated parameter context values on restart") | |
| .withDescription("Reload provider-generated parameter context values when MiNiFi is restarted") |
| "description": "", | ||
| "sensitive": true, | ||
| "provided": true, | ||
| "value": "old_secret_minifi_data_value" |
There was a problem hiding this comment.
This value would more realistically be property_encryption::encrypt("old_secret_minifi_data_value", encryption_provider), right? I think we could do that with a fmt::format().
If you want to leave it as it is for simplicity, that's fine, too, but then maybe change it to something like "old_secret_minifi_data_value_encrypted".
| @@ -53,20 +53,11 @@ void JsonFlowSerializer::addProviderCreatedParameterContexts(rapidjson::Value& f | |||
| } | |||
|
|
|||
| std::unordered_set<std::string> parameter_context_names; | |||
There was a problem hiding this comment.
parameter_context_names is unused, could be removed (in the YAML version, too)
https://issues.apache.org/jira/browse/MINIFICPP-2509
depends on #1895
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.