system/flatbuffers: fix patch flow of flatbuffers #2869
Merged
+47
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
force-pushed
the
24112801
branch
3 times, most recently
from
e852e1f
to
e44f1ad
Compare
Applying patch to flatbuffers patching file '<' Hunk apache#1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk apache#1 FAILED at 39. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk apache#1 FAILED at 495. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk apache#1 FAILED at 23. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patch: **** Can't reopen file '<' : No such file or directory -- Configuring done (12.8s) -- Generating done (0.3s) Signed-off-by: chao an <[email protected]>
Signed-off-by: chao an <[email protected]>
…be compile Signed-off-by: chao an <[email protected]>
1. correct include patch of support library 2. add flatbuffers include path Signed-off-by: chao an <[email protected]>
ruy is not really used, tflite just uses the header file Error log from CMake: ================================================================ -- Configuring done (2.1s) CMake Error at cmake/nuttx_add_library.cmake:183 (add_library): No SOURCES given to target: ruy Call Stack (most recent call first): apps/math/ruy/CMakeLists.txt:57 (nuttx_add_library) Signed-off-by: chao an <[email protected]>
Signed-off-by: chao an <[email protected]>
|
@xiaoxiang781216 done, please review again, ci is broken now |
cederom
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
Looks and builds fine now, thank you @xiaoxiang781216 for the remarks :-) Thank you @anchao for the updates :-)
|
I have tested this commit locally and found no other problems. Let's merge this commit first to resolve the CI broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
system/flatbuffers: fix patch flow of flatbuffers
Signed-off-by: chao an [email protected]
Impact
N/A
Testing
sim/nsh and enable CONFIG_SYSTEM_FLATBUFFERS