Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website #73

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 2, 2022

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks @rzo1 !

@jzonthemtn jzonthemtn mentioned this pull request Dec 2, 2022
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kinow
Copy link
Member

kinow commented Dec 2, 2022

Just waiting for Travis (:man_shrugging: even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer).

@rzo1
Copy link
Contributor Author

rzo1 commented Dec 2, 2022

Just waiting for Travis (man_shrugging even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer).

Guess we need to migrate away from Travis CI any time soon. I read, that ASF discontinous to use it, so we obviously need to change that in the future.

@kinow
Copy link
Member

kinow commented Dec 2, 2022

True, LGTM. I think I saw an email from... INFRA? Telling projects to migrate away from Travis. Merging and updating JIRA. Thanks!

@kinow kinow merged commit d1ee6bb into master Dec 2, 2022
@kinow kinow deleted the OPENNLP-1399 branch December 2, 2022 15:13
@jzonthemtn
Copy link
Contributor

@rzo1 @kinow I could be wrong, but I don't think Travis CI is doing anything here and we can just delete the .travis.yml file. Pushing a commit triggers build bot and it does the deploy.

@kinow
Copy link
Member

kinow commented Dec 3, 2022

@rzo1 @kinow I could be wrong, but I don't think Travis CI is doing anything here and we can just delete the .travis.yml file. Pushing a commit triggers build bot and it does the deploy.

Sounds good to me. Either delete it or replace by GH Actions to just build JBake/Maven. Either way would be better than having Travis as it's really slow these days 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants