Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dark mode for project's website #85

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Provide dark mode for project's website #85

merged 1 commit into from
Sep 4, 2023

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Sep 1, 2023

Background

I starred into my laptop's screen while browsing OpenNLP's website at night. It was not comforting for my eyes, at all. Therefore, I decided to create and propose a dark theme for the community.

Change

  • provides new CSS files for dark and light CSS-based themes
  • integrates new themes via header.ftl

Testing

Steps for local preview:

Notes

The approach is purely user driven (via browser or OS-preferences). Depending on the client's preferences the light theme or dark theme will be chosen and displayed by the browser.

Feedback welcome!

@mawiesne mawiesne assigned atarora and unassigned atarora Sep 1, 2023
@mawiesne mawiesne requested a review from atarora September 1, 2023 21:10
@mawiesne mawiesne changed the title Provide dark theme for project's website Provide dark mode for project's website Sep 1, 2023
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vary between dark & light via DarkReader, but +1, I think this will detect the system choice and display light or dark. Thanks!

Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice! My eyes aren't bleeding anymore.

@rzo1 rzo1 merged commit 2be9342 into main Sep 4, 2023
@rzo1 rzo1 deleted the provide-dark-theme branch September 4, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants