HDDS-11634. Publish images to Docker Hub from GitHub workflow #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that the image pushed by tag only has amd64 platform. Will reopen this once I fix that. |
|
Fixed tagging of multi-arch images: ghcr.io, hub.docker.com. Reference: |
smengcl
approved these changes
Nov 7, 2024
Co-authored-by: Siyao Meng <[email protected]>
|
Thanks @smengcl for the review. |
|
Thanks @adoroszlai for the patch! |
adoroszlai
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit c36597a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Publish
ozone-runnerDocker images created by the CI workflow to Docker Hub, in addition to existing practice.Only publish images with tags, not by Git commit SHA (the latter is used only for GitHub Container Registry).
Publishing to Docker Hub is optional, only done if the secrets are defined for the repo. This way the workflow is still functional in forks whose owners have not set up Docker Hub repository. (Example run before I set up secrets in my fork.)
https://issues.apache.org/jira/browse/HDDS-11634
How was this patch tested?
Workflow published the image to both GitHub and Docker Hub.
Secrets set by Apache Infra on this repo will be tested when this is merged and the commit tagged.
Once we confirm this to be working, we can ask Infra to disable the Docker Hub automated build.