Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11540. Use git submodules for Chart Actions #6

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Oct 6, 2024

What changes were proposed in this pull request?

The PR fixes usage of GitHub Actions needed for the chart testing.
Similar to apache/superset#14211 and apache/superset#12709

Commands used to add submodules:

git submodule add --force https://github.com/helm/chart-testing-action .github/actions/chart-testing-action
cd .github/actions/chart-testing-action
git checkout e6669bcd63d7cb57cb4380c33043eebe5d111992

git submodule add --force https://github.com/helm/kind-action .github/actions/kind-action
cd .github/actions/kind-action
git checkout 0025e74a8c7512023d06dc019c617aa3cf561fde

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11540

How was this patch tested?

Tested in the fork repo with restricted actions:

Screenshot 2024-10-06 at 17 47 07

@dnskr
Copy link
Contributor Author

dnskr commented Oct 6, 2024

@adoroszlai Please review when you have time.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnskr for the patch.

I noticed a mismatch in submodule commit hashes:

  1. PR description, .gitmodules match previous state of test.yaml:
    • chart-testing-action: e6669bcd63d7cb57cb4380c33043eebe5d111992
    • kind-action: 0025e74a8c7512023d06dc019c617aa3cf561fde
  2. .github/actions (as shown in PR) and checkout log refer to the current HEAD in the source repos:
    • chart-testing-action: 5aa1c68405a43a57240a9b2869379324b2bec0fc
    • kind-action: 5d66646e5edb36c6b25badc52b0b19936b5fad66

It's OK to add the latest commits instead of those that used to be latest acouple of months ago. But I'd like to know the source of this mismatch, and whether the submodules are actually pinned or not.

@dnskr dnskr force-pushed the use-git-submodules-for-chart-actions branch from 8b22d76 to 400c424 Compare October 6, 2024 22:14
@dnskr dnskr force-pushed the use-git-submodules-for-chart-actions branch from 400c424 to c3d89a6 Compare October 6, 2024 22:18
@dnskr
Copy link
Contributor Author

dnskr commented Oct 6, 2024

@adoroszlai Thank you for the review.
I made a mistake because I never used git submodules before. Great that you found the issue.
I fixed commit hashes (and description) for submodules and know the submodules point to pinned action versions.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnskr for updating the patch, LGTM.

@adoroszlai adoroszlai merged commit ce96199 into apache:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants