Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Refactor usage of DropwizardAppExtension in the tests for PolarisApplication to maximize the reuse #502

Open
gh-yzou opened this issue Dec 2, 2024 · 1 comment · May be fixed by #504
Open

[FEATURE REQUEST] Refactor usage of DropwizardAppExtension in the tests for PolarisApplication to maximize the reuse #502

gh-yzou opened this issue Dec 2, 2024 · 1 comment · May be fixed by #504
Labels
enhancement New feature or request

Comments

@gh-yzou
Copy link

gh-yzou commented Dec 2, 2024

Is your feature request related to a problem? Please describe.

There are a lot of tests uses DropwizardAppExtension to init a PolarisApplication, for example:

private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
      new DropwizardAppExtension<>(
          PolarisApplication.class,
          ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
          // Bind to random port to support parallelism
          ConfigOverride.config("server.applicationConnectors[0].port", "0"),
          ConfigOverride.config("server.adminConnectors[0].port", "0"),
          // Block overlapping catalog paths:
          ConfigOverride.config("featureConfiguration.ALLOW_OVERLAPPING_CATALOG_URLS", "false"));

in PolarisOverlappingCatalogTest.java.

Describe the solution you'd like

We can refactor the usaage as a util function or base class for maximize reuse.

Describe alternatives you've considered

No response

Additional context

No response
@gh-yzou gh-yzou added the enhancement New feature or request label Dec 2, 2024
@gh-yzou
Copy link
Author

gh-yzou commented Dec 2, 2024

i am working on this

@gh-yzou gh-yzou linked a pull request Dec 2, 2024 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-502] refactor test gh-yzou/polaris
1 participant
@gh-yzou