Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-502] refactor test #504

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gh-yzou
Copy link

@gh-yzou gh-yzou commented Dec 2, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #502

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

@gh-yzou gh-yzou changed the title Yzou issue 502 refactor test ISSUE 502 refactor test Dec 2, 2024
@gh-yzou gh-yzou changed the title ISSUE 502 refactor test [ISSUE-502] refactor test Dec 2, 2024
@gh-yzou gh-yzou force-pushed the yzou-issue-502-refactor-test branch from 5b91c75 to c4ab31e Compare December 3, 2024 01:43
@adutra
Copy link
Contributor

adutra commented Dec 3, 2024

I think this is an interesting idea, but I think that the application should be managed by TestEnvironmentExtension. Because this extension is capable of switching application instances already, but it only exposes the base URL of the application. In order for it to work properly, it should expose the whole application imho. Otherwise it cannot be effective for tests that need to interact with specific components of the application, such as TimedApplicationEventListenerTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants