Update default dlq producer name #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geniusjoe
force-pushed
the
doc/update-default-dlq-name
branch
2 times, most recently
from
ab64251 to
c2ada05
Compare
|
@lhotari Hello Lari, would you mind reviewing this pr? Thanks. |
geniusjoe
force-pushed
the
doc/update-default-dlq-name
branch
from
c2ada05 to
38657cc
Compare
RobertIndie
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Contribution Checklist
Motivation
Issue: apache/pulsar-client-go#1297
Root issue: apache/pulsar#21589
New default dlq producer names are in the form of
opt.Name = fmt.Sprintf("%s-%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName, generateRandomName())in branch4.0.xand3.3.x(apache/pulsar#23645), so that we need to update related documents as well.Modification
Current
https://pulsar.apache.org/docs/4.0.x/concepts-messaging/#dead-letter-topic
Preview
