Skip to content

Commit

Permalink
Fix to Ensure not isInterface requirement applied to all conditions (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
wengyingjian authored Jun 3, 2024
1 parent f736b37 commit 313d7d5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Release Notes.
* Support for showing batch command details and ignoring PING commands in Redisson plugin.
* Fix peer value of Master-Slave mode in Redisson plugin.
* Support for tracing the callbacks of asynchronous methods in elasticsearch-6.x-plugin/elasticsearch-7.x-plugin.
* Fixed the invalid issue in the isInterface method in PluginFinder.

All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,14 @@ public boolean matches(NamedElement target) {
return nameMatchDefine.containsKey(target.getActualName());
}
};
judge = judge.and(not(isInterface()));
for (AbstractClassEnhancePluginDefine define : signatureMatchDefine) {
ClassMatch match = define.enhanceClass();
if (match instanceof IndirectMatch) {
judge = judge.or(((IndirectMatch) match).buildJunction());
}
}
// Filter out all matchers returns to exclude pure interface types.
judge = not(isInterface()).and(judge);
return new ProtectiveShieldMatcher(judge);
}

Expand Down

0 comments on commit 313d7d5

Please sign in to comment.