Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but RoutingSupport#determineHost works. #674

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but RoutingSupport#determineHost works. #674

merged 2 commits into from
Mar 12, 2024

Conversation

cylx3126
Copy link
Contributor

MRE here.

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
  • Update the CHANGES log.

@cylx3126
fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecu…
df7b281 
…te is null, hc5 would send request but the agent don't create span
@wu-sheng wu-sheng self-requested a review March 12, 2024 14:14
@wu-sheng wu-sheng added this to the 9.2.0 milestone Mar 12, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Mar 12, 2024
wu-sheng
wu-sheng reviewed Mar 12, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@wu-sheng wu-sheng changed the title Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but RoutingSupport#determineHost works. Mar 12, 2024
@wu-sheng wu-sheng merged commit 466f173 into apache:main Mar 12, 2024
188 checks passed
@cylx3126 cylx3126 deleted the fix_hc5 branch March 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working plugin
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cylx3126 @wu-sheng