More jdk upgrade #2868
Open
More jdk upgrade #2868
+3
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
approved these changes
Nov 17, 2024
malliaridis
approved these changes
Nov 18, 2024
|
I have had to futz around a bit with SSLTestConfig.java to get tests to run, so it would be great to get this in and see if it prevents me tweaking that class! |
|
@epugh I was just removing checks that shouldn't matter anymore, if I recall. What error did you see? |
I will have to try and recreate it... I don't remember, but I do remember commenting out some methods. It may be the migration to intellj,jdk upgrade, and changing how I run tests... If I can duplicate the errors I'll speak up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some more code to remove/change due to the JDK upgrade... see the separate commits
@hossman tagging you for review on the SSL compatibility check removal, especially
@dweiss for a couple build files
@HoustonPutman for the Lookup.ensureInitialized thing