[SPARK-53396][SQL] Improve error message when input of GetStructField is not StructType
#52142
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Aug 27, 2025
| @@ -148,7 +148,10 @@ trait ExtractValue extends Expression with QueryErrorsBase { | |||
| case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None) | |||
| extends UnaryExpression with ExtractValue { | |||
|
|
|||
| lazy val childSchema = child.dataType.asInstanceOf[StructType] | |||
There was a problem hiding this comment.
The assumption is that the child must be StructType so that we will construct GetStructField.
| @@ -148,7 +148,10 @@ trait ExtractValue extends Expression with QueryErrorsBase { | |||
| case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None) | |||
| extends UnaryExpression with ExtractValue { | |||
|
|
|||
| lazy val childSchema = child.dataType.asInstanceOf[StructType] | |||
| lazy val childSchema = child.dataType match { | |||
There was a problem hiding this comment.
Are we sure that this is a error message improvement and not an actual bug in the analyzer? It might be that somehow we don't apply type coercion correctly or similar, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve error message when input of
GetStructFieldis notStructTypeWhy are the changes needed?
Previously we threw a class cast exception.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case.
Was this patch authored or co-authored using generative AI tooling?
No