[MINOR][CONNECT] Fix typos in ExecuteGrpcResponseSender.scala #52143
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +76,7 @@ private[connect] class ExecuteGrpcResponseSender[T <: Message]( | |||
| } | |||
|
|
|||
| // For testing | |||
| private[connect] def setDeadline(deadlineNs: Long) = { | |||
| private[connect] def setDeadline(deadlineNs: Long): Unit = { | |||
There was a problem hiding this comment.
I'd like to give you just one tiny advice to you, @luisteod . Please don't mix irrelevant themes into a single PR. This is not a typo fix.
There was a problem hiding this comment.
Got it! May I just leave the comments typo fix?
There was a problem hiding this comment.
Simply revert this line change by removing : Unit back?
| @@ -300,10 +301,10 @@ private[connect] class ExecuteGrpcResponseSender[T <: Message]( | |||
| if (sent) { | |||
| sentResponsesSize += response.get.serializedByteSize | |||
| nextIndex += 1 | |||
| assert(finished == false) | |||
| assert(!finished) | |||
There was a problem hiding this comment.
ditto. This is not a type fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fix typos in ExecuteGrpcResponseSender.scala
Why are the changes needed?
For readability improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run manual tests
Was this patch authored or co-authored using generative AI tooling?
No