feat: allow exporting all tabs to a single PDF in report

[US579]

SUMMARY

This update will give user an option to export all tabs if there are more then one in a dashboard, all tabs will be included in a single PDF document

ANIMATED GIF

BEFORE/AFTER SCREENSHOTS

Before user could only include one tab into a PDF report

example output:

1_ FCC New Coder Survey 2018 (1).pdf

After user could choose to include all tabs to their report

example output:
1_ FCC New Coder Survey 2018.pdf

NOTE: This feature can also be modified to include specific tabs in the email, but it would require changes on the frontend (allow users to select multiple tabs).

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: this need to enable feature flag: ALERT_REPORT_TABS
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[codecov]

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.77%. Comparing base (76d897e) to head (36dc62a).
Report is 921 commits behind head on master.

Files with missing lines	Patch %	Lines
...-frontend/src/features/alerts/AlertReportModal.tsx	9.09%	9 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30694       +/-   ##
===========================================
+ Coverage   60.48%   70.77%   +10.29%     
===========================================
  Files        1931     1987       +56     
  Lines       76236    80260     +4024     
  Branches     8568     9171      +603     
===========================================
+ Hits        46114    56808    +10694     
+ Misses      28017    21221     -6796     
- Partials     2105     2231      +126     

Flag	Coverage Δ
hive	?
javascript	58.60% <9.09%> (+0.88%)	⬆️
mysql	76.75% <94.73%> (?)
postgres	76.87% <94.73%> (?)
presto	53.38% <10.52%> (-0.43%)	⬇️
python	83.82% <100.00%> (+20.33%)	⬆️
sqlite	76.32% <94.73%> (?)
unit	60.91% <42.10%> (+3.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

Running CI again... let me know if you want me to keep clicking the button, or if you have tests running locally ;)

[US579]

Running CI again... let me know if you want me to keep clicking the button, or if you have tests running locally ;)

ah sorry my bad, should have run all the tests

[eschutho]

/testenv up FEATURE_ALERT_REPORTS=True FEATURE_ALERT_REPORT_TABS = True

[eschutho]

LGTM. Thanks @US579!

[github-actions]

@eschutho Ephemeral environment spinning up at http://35.163.133.83:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[yousoph]

Hi @US579 ! Thanks for adding this feature :)

We noticed that the all tabs export doesn't seem to export the tabs in any specific order (our report with 3 tabs exported with tab 2, then 3, then 1 in the PDF). Would you be open to making an enhancement to export the tabs in the order they appear in the dashboard?

Thanks!

[US579]

thanks for the feedback @yousoph ! yep i will take a look and get back to you

[US579]

Hi @US579 ! Thanks for adding this feature :)

We noticed that the all tabs export doesn't seem to export the tabs in any specific order (our report with 3 tabs exported with tab 2, then 3, then 1 in the PDF). Would you be open to making an enhancement to export the tabs in the order they appear in the dashboard?

Thanks!

thanks for the feedback again! I have created an MR for fixing the order issue here
#30888

[lihan]

Can we get this into a stable release?